Bit of an update.
Was still getting a mild bumping noise, that could be felt under drivers seat.
So whilst having the rear wheel off to check bushes i decided to pull spring off and have a good look.
All ok. I washed the top and bottom rubber mounts and refitted spring.
All bumping noise gone?
Having just got access to BMW TIS document it mentions spring problems on another model of BMW. Problem being the barrel spring gripping rubber mount and then rebounds with a bump.
When i bought the car there was a problem with a knocking noise sounding like someone hitting the bottom of the boot with a rubber mallet. Initial cure was grease on anti roll bar bushes, then i replaced bushes with polybushes. But always thought this was a sticking plaster to the real problem.
BMW solution was to talcum powder the top rubber of the springs, which i have yet to try, simply because disturbing the spring and washing the rubbers seems to have cured the problem.
Update 29/04. I checked the spring and i noticed that i have rotated the spring when installed to a different position. The letters S1 was printed on the spring visible on the outside which must now be near the back of spring as viewed as i can't see it. Seems to have cured the clunks and bumps.
Might invest in two new upper rubbers, they are shaped like traditional Amish mens hat and have noticed the one washed, the 'rim' is floppy when under spring load as it bares only around the centre and could be flapping against the bodywork when the spring goes up and down. Might be idea to glue the rubber to bodywork.